From 336f1453b95129fdda111f8ff84b240722df0134 Mon Sep 17 00:00:00 2001
From: Robert Garrett <robertgarrett404@gmail.com>
Date: Wed, 2 Jul 2025 22:51:58 -0500
Subject: [PATCH] Address most of the cargo-clippy lints

---
 src/api/release.rs            | 6 +++---
 src/api/release_attachment.rs | 2 +-
 src/main.rs                   | 4 ++--
 src/structs/release.rs        | 2 +-
 4 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/api/release.rs b/src/api/release.rs
index 4250d3f..a3f4917 100644
--- a/src/api/release.rs
+++ b/src/api/release.rs
@@ -20,7 +20,7 @@ pub async fn list_releases(
 ) -> Result<Vec<Release>> {
     let request_url = format!("{gitea_url}/api/v1/repos/{repo}/releases/");
     let req = client.get(request_url).send().await;
-    let response = req.map_err(|reqwest_err| crate::Error::WrappedReqwestErr(reqwest_err))?;
+    let response = req.map_err(crate::Error::WrappedReqwestErr)?;
     if response.status().is_success() {
         let release_list = response
             .json::<Vec<Release>>()
@@ -50,12 +50,12 @@ pub async fn create_release(
         .json(&submission)
         .send()
         .await
-        .map_err(|e| crate::Error::from(e))?;
+        .map_err(crate::Error::from)?;
     if response.status().is_success() {
         let new_release = response
             .json::<Release>()
             .await
-            .map_err(|e| crate::Error::from(e))?;
+            .map_err(crate::Error::from)?;
         return Ok(new_release);
     } else if response.status().is_client_error() {
         let mesg = crate::decode_client_error(response).await?;
diff --git a/src/api/release_attachment.rs b/src/api/release_attachment.rs
index ae626ef..706192f 100644
--- a/src/api/release_attachment.rs
+++ b/src/api/release_attachment.rs
@@ -44,7 +44,7 @@ pub async fn create_release_attachment(
         let attachment_desc = response
             .json::<Attachment>()
             .await
-            .map_err(|e| crate::Error::from(e))?;
+            .map_err( crate::Error::from)?;
         return Ok(attachment_desc);
     } else if response.status().is_client_error() {
         let mesg = crate::decode_client_error(response).await?;
diff --git a/src/main.rs b/src/main.rs
index e5c1dd2..04fbbe4 100644
--- a/src/main.rs
+++ b/src/main.rs
@@ -36,7 +36,7 @@ async fn main() -> Result<(), gt_tool::Error> {
             // Print in reverse order so the newest items are closest to the
             // user's command prompt. Otherwise the newest item scrolls off the
             // screen and can't be seen.
-            let _ = itertools::Itertools::intersperse(
+            itertools::Itertools::intersperse(
                 releases
                     .iter()
                     .rev()
@@ -152,5 +152,5 @@ fn match_release_by_tag(tag: &String, releases: Vec<Release>) -> Option<Release>
             }
         }
     }
-    return release;
+    release
 }
diff --git a/src/structs/release.rs b/src/structs/release.rs
index 365d171..4888350 100644
--- a/src/structs/release.rs
+++ b/src/structs/release.rs
@@ -28,7 +28,7 @@ impl Release {
         let published = "Published:".bright_green();
         let created = "Created:".green().dimmed();
         let author = "Author:".blue();
-        let body = if self.body.len() > 0 {
+        let body = if !self.body.is_empty() {
             &self.body.white()
         } else {
             &String::from("(empty body)").dimmed()